Problem with two or more players using the same bid

[drakos01]

The problem is about item bidding. Lets assume that person A bids for 10 and person B bids for 10 dkp after person A. Then the winner is person B (addon says that). But in my opinion the winner is the first person that used highest bid. All people that bid after him should use only higher bids.

To fix it I have placed 3 lines of code in Bidding.lua file:
in line 296:

Code:

local highBidder, highBid = WebDKP_Bid_GetHighestBid();

in line 313:

Code:

elseif((cmd) <= highBid) then
WebDKP_SendWhisper(name,"Bid not accepted. It's lower or equal to current bid! Current bid is "..highBid);

the code looks now like this (starting from line 288):

Code:

function WebDKP_Bid_Event()
local name = arg2;
local trigger = arg1;
if(WebDKP_IsBidChat(name,trigger)) then
local cmd, subcmd = WebDKP_GetCmd(trigger);
cmd, subcmd = WebDKP_GetCommaCmd(subcmd);
startbiddingcmd = cmd;
cmd = tonumber(cmd);
local highBidder, highBid = WebDKP_Bid_GetHighestBid();


-- SOMEONE HAS PLACED A BID
if (string.find(string.lower(trigger), "!bid ") == 1) then
if cmd == nil then
WebDKP_SendWhisper(name,"You did not bid properly, use !bid #");
else
if(WebDKP_bidInProgress == false) then
WebDKP_SendWhisper(name,"There is no bid in progress");
elseif(cmd == "") then
WebDKP_SendWhisper(name,"You did not specify a bid amount - bid not accepted");
elseif((cmd) < WebDKP_GetStartingBid() ) then
WebDKP_SendWhisper(name,"Bid not accepted. The minimum bid is "..WebDKP_GetStartingBid());
elseif(WebDKP_Options["BidFixedBidding"]==1) then
WebDKP_SendWhisper(name,"Bid not accepted. You must type !need");
elseif(WebDKP_Options["DisableBid"]==1) then
WebDKP_SendWhisper(name,"Bid not accepted. Please use !main value or !off value");
elseif((cmd) <= highBid) then
WebDKP_SendWhisper(name,"Bid not accepted. It's lower or equal to current bid! Current bid is "..highBid);
else
WebDKP_Bid_HandleBid(name,cmd, "NA");
WebDKP_SendWhisper(name,"Bid for "..cmd.." dkp accepted");
end
end
-- SOMEONE WANTS TO BID ALL THEIR DKP

After my fix only higher bids are accepted. Though I haven't think about rolls and advanced bidding system including main-,off-specs, alts, greeds and neeeds. I don't need them at the moment.

[Zevious]

Yep I believe most people have handled this by having tied people roll then the winner of the roll wins. Your fix would work for most systems except for people using a silent bidding system. In the silent bid system if it responded saying bid not accepted you could easily bid just one pt more and ensure you beat the person you tied with. I will look at this more soon and establish some fixes based on the in game settings. Thanks for the post.